-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement validation loss using FID scores and add corresponding documentation #326
base: master
Are you sure you want to change the base?
Conversation
The previous logic incorrectly triggered sampling *before* each epoch, including before the start of training (of first epoch). This fix ensures sampling functions are processed only after a full epoch of training is completed.
- Create a hidden "epochs" folder to store epoch-specific sample subfolders - Set the "Hidden" attribute for the "epochs" folder using ctypes.windll.kernel32.SetFileAttributesW
… a set of validation images.
This commit adds the calculation of FID scores during the training process. It leverages the `calculate_fid_scores` script and integrates it into the `__sample_during_training` method. The FID scores are computed using the validation images specified in the `concepts.json` file and the generated samples saved in the hidden "epochs" directory.
I like the idea of adding validation loss. But there are several issues with your implementation that would need to be resolved before it can be merged. Just naming a few here, but there are definitely more problems.
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Addressing point 1:
The current pull request places the validation image configuration within the concepts tab, which is not ideal. To improve the user experience and address organizational issues, I propose the following changes:
Example for new structure: @Nerogar : What do you think about this? Footnotes
|
Description
This pull request introduces the implementation of validation loss using FID (Fréchet Inception Distance) scores and provides comprehensive documentation for this feature (for the wiki). The implementation includes:
The accompanying documentation covers the following aspects:
concepts.json