Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Resource]: Ethernet Port #334

Open
wants to merge 16 commits into
base: integration/main
Choose a base branch
from
Open

[New Resource]: Ethernet Port #334

wants to merge 16 commits into from

Conversation

acch
Copy link

@acch acch commented Nov 13, 2024 •
edited
Loading

Adds ability to create ethernet ports (VLAN / LAG).

Closes #304.

Acceptance tests pass:

TF_ACC=1 go test ./internal/provider/networking/network_ethernet_port_resource_test.go -v
=== RUN   TestAccNetworkEthernetPortResource
--- PASS: TestAccNetworkEthernetPortResource (16.33s)
PASS
ok      command-line-arguments  16.338s

Example Terraform Configurations:

// sample LAG with required properties
resource "netapp-ontap_port" "lag" {
  cx_profile_name = ...

  broadcast_domain = {
    ipspace = "Default"
    name    = "bd1"
  }

  node = {
    name = "node1"
  }

  type = "lag"
  lag = {
    distribution_policy = "mac"
    member_ports = [ "e0b", "e0c" ]
    mode = "singlemode"
  }
}
// sample VLAN with required properties
resource "netapp-ontap_port" "vlan" {
  cx_profile_name = ...

  broadcast_domain = {
    ipspace = "Default"
    name    = "bd2"
  }

  node = {
    name = "node1"
  }

  type = "vlan"
  vlan = {
    base_port = "e0a"
    tag       = 100
  }
}

@acch acch marked this pull request as ready for review November 20, 2024 10:35
@acch acch mentioned this pull request Nov 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carchi8py carchi8py Awaiting requested review from carchi8py carchi8py is a code owner

@chuyich chuyich Awaiting requested review from chuyich chuyich is a code owner

@suhasbshekar suhasbshekar Awaiting requested review from suhasbshekar suhasbshekar is a code owner

@wenjun666 wenjun666 Awaiting requested review from wenjun666 wenjun666 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Resource]: VLAN (ethernet ports)
1 participant
@acch