Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interface location.broadcast_domain parameter #337

Draft
wants to merge 6 commits into
base: integration/main
Choose a base branch
from
Draft

Add interface location.broadcast_domain parameter #337

wants to merge 6 commits into from

Conversation

acch
Copy link

@acch acch commented Nov 20, 2024 •
edited
Loading

Adds ability to configure location.broadcast_domain parameter of IP Interfaces.

Closes #305.

Acceptance tests WIP:

$ TF_ACC=1 go test ./internal/provider/networking/network_ip_interface_resource_test.go -v
...
$ TF_ACC=1 go test ./internal/provider/networking/network_ip_interface_resource_alias_test.go -v
...

Example Terraform Configurations:

resource "netapp-ontap_network_ip_interface" "with_node_port" {
  cx_profile_name = ...
  name            = ...
  svm_name        = ...

  ip = { ... }

  location = {
    home_port = "e0a-100"
    home_node = "node1"
  }
}
resource "netapp-ontap_network_ip_interface" "with_broadcast_domain" {
  cx_profile_name = ...
  name            = ...
  svm_name        = ...

  ip = { ... }

  location = {
    broadcast_domain = {
      name = "bd1"
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carchi8py carchi8py Awaiting requested review from carchi8py carchi8py will be requested when the pull request is marked ready for review carchi8py is a code owner

@chuyich chuyich Awaiting requested review from chuyich chuyich will be requested when the pull request is marked ready for review chuyich is a code owner

@suhasbshekar suhasbshekar Awaiting requested review from suhasbshekar suhasbshekar will be requested when the pull request is marked ready for review suhasbshekar is a code owner

@wenjun666 wenjun666 Awaiting requested review from wenjun666 wenjun666 will be requested when the pull request is marked ready for review wenjun666 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Add interface location.broadcast_domain parameter
1 participant
@acch