Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward port 2.x code quality improvements to 3.x #944

Closed
rdmark opened this issue May 2, 2024 · 2 comments
Closed

Forward port 2.x code quality improvements to 3.x #944

rdmark opened this issue May 2, 2024 · 2 comments
Assignees

Comments

@rdmark
Copy link
Member

rdmark commented May 2, 2024

There are a handful of minor improvements that were made in 2.x that should be ported to 3.x, e.g. this commit bda8274

Examples include safety checks in afppasswd.c

@rdmark
Copy link
Member Author

rdmark commented May 6, 2024

I was able to port most relevant patches cleanly in #952

Two patches I'm holding back for now because they don't apply cleanly to main, and some deeper reading is required to make sure there are no side effects:

34c6c30
9a75cb8

@rdmark rdmark self-assigned this May 6, 2024
@rdmark
Copy link
Member Author

rdmark commented May 25, 2024

The former now done with #1023

The latter is just cleanup of unused variables. That can be done at a later time for the codebase as a whole.

@rdmark rdmark closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant