Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace oauth2client with google-auth #79

Open
andrewmwhite opened this issue Oct 2, 2017 · 3 comments
Open

Replace oauth2client with google-auth #79

andrewmwhite opened this issue Oct 2, 2017 · 3 comments

Comments

@andrewmwhite
Copy link
Contributor

oauth2client has been deprecated in favor of google-auth. Stethoscope's use of oauth2client to interact with Google's APIs should therefore be replaced with google-auth, particularly since the former is no longer being supported.

@suprithcs
Copy link

Hi Andrew, I'm interested to take this up. I'm new to the code base. I did run a grep on the repo and found some places that needs change. However, I'd like to hear from you about where the changes should be made. Also, best way to test the changes. I'll send out a pr in couple days. Thanks

@andrewmwhite
Copy link
Contributor Author

Hi Suprith,

Thanks for your interest in contributing to Stethoscope! One caveat that just occurred to me with implementing this is you'll need a Google Apps service account set up and running for testing. If you don't have access to that, you might want to look around for other ways to contribute.

I looked through the codebase and it seems like the changes that need to be made are:

@suprithcs
Copy link

Hi Andrew, Thank you for the prompt response. I don't have a service account to test the changes because I don't run any instance on GCP. Do we have any work-around? If not, please recommend some other issue/feature that I can work on. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants