Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider moving packages such that other non-netflix companies would see better example #10

Open
aspyker opened this issue Aug 1, 2013 · 2 comments

Comments

@aspyker
Copy link
Contributor

aspyker commented Aug 1, 2013

I think most other applications will need to specify

com.netflix.karyon.server.base.packages

To get governator working. I think you have been able to avoid this in the rss-recipes config as it defaults to com.netflix and your sample is in com.netflix.

Please note if this is incorrect and close or take this as suggestion that should be documented.

@NiteshKant
Copy link

+1

@cfregly
Copy link
Contributor

cfregly commented Aug 3, 2013

confirmed.

flux specifies com.netflix.karyon.server.base.packages=com.fluxcapacitor in the following 2 files:

https://github.com/cfregly/fluxcapacitor/blob/master/flux-middletier/src/main/resources/middletier.properties
https://github.com/cfregly/fluxcapacitor/blob/master/flux-edge/src/main/resources/edge.properties

and if i remove it, i see a form of the following:

com.google.inject.ConfigurationException: Guice configuration errors:
...
at com.google.inject.internal.InjectorImpl.getBinding(InjectorImpl.java:150)
at com.google.inject.internal.InjectorImpl.getBinding(InjectorImpl.java:66)
at com.sun.jersey.guice.spi.container.GuiceComponentProviderFactory.getComponentProvider(GuiceComponentProviderFactory.java:136)

@pprasanna: definitely worth adding this to recipes-rss.

@aspyker: good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants