make it clear that MaxFee field is not used anymore for V3 tx + improve comments for Transactions
#2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2130 +/- ##
==========================================
- Coverage 78.33% 78.31% -0.03%
==========================================
Files 100 100
Lines 9221 9221
==========================================
- Hits 7223 7221 -2
Misses 1357 1357
- Partials 641 643 +2 ☔ View full report in Codecov by Sentry. |
TAdev0
changed the title
MaxFee field is not used anymore for V3 txMaxFee field is not used anymore for V3 tx + improve comments
TAdev0
changed the title
MaxFee field is not used anymore for V3 tx + improve commentsMaxFee field is not used anymore for V3 tx + improve comments for Transactions
rianhughes
approved these changes
Sep 11, 2024
|
This pull request is stale because it has been open 35 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2129
also reorganize fields to make it clearer in general