You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This issue outlines how external contributors could really help out the starknet.go package by helping to increase the test coverage for starknet.go's rpc package. See the readme for the list of starknet methods. I would also recommend looking at existing test cases for help.
A good approach would be to start with the read methods (those that don't require gas/fee tokens, eg, getTransactionByHash, starknet_getBlockWithTxs, etc), and with mock environments (doesn't require starknet endpoint). Only once you are very comfortable working with these would I recommend starting to work on devnet environments, and then testnet/mainnet environments.
If you are interested in starting a new issue please:
Create a new issue outlining which (method,environment) you would like to work on. Eg "Increase test coverage of (starknet_getNonce, mock)". Adding comments in the issue can help reviews.
Fork the repo, or create a new branch
Implement test cases for that method
When all github tests pass on your branch, create a PR, linking to the original issue you created.
Request a review
Ideally we should test successful requests (eg getTransactionByHash with a valid hash), and failing requests (eg getTransactionByHash with an invalid hash). And if a method can work with multiple argument types (eg AddInvokeTranscation accepts BroadcastInvokev0Txn, and BroadcastInvokev1Txn, so we should test both of these etc.), we should also add a test case for that.
To run the tests in the rpc package:
Enter the directory
run "go test . -env mock -v". Currently we test mock, devnet, testnet and mainnet environments (although a lot of these are empty tests)
The text was updated successfully, but these errors were encountered:
@rianhughes, I see this one has been open for some time.
I have good experience working with Go in distributed systems; and most of it has been writing test suites 😅.
Is it okay if I take up this issue, and start working on it? I see you've been doing the heavy lifting with the recent PRs, and I would love to be able to contribute :D
@rianhughes Nice work! I'd also love to contribute and learning more about Starknet. Is it okay if I also take a look at this issue? Appreciate the work you've been doing on this recently and I would love to contribute in some way as well.
This issue outlines how external contributors could really help out the starknet.go package by helping to increase the test coverage for starknet.go's rpc package. See the readme for the list of starknet methods. I would also recommend looking at existing test cases for help.
A good approach would be to start with the read methods (those that don't require gas/fee tokens, eg, getTransactionByHash, starknet_getBlockWithTxs, etc), and with mock environments (doesn't require starknet endpoint). Only once you are very comfortable working with these would I recommend starting to work on devnet environments, and then testnet/mainnet environments.
If you are interested in starting a new issue please:
Ideally we should test successful requests (eg getTransactionByHash with a valid hash), and failing requests (eg getTransactionByHash with an invalid hash). And if a method can work with multiple argument types (eg AddInvokeTranscation accepts BroadcastInvokev0Txn, and BroadcastInvokev1Txn, so we should test both of these etc.), we should also add a test case for that.
To run the tests in the rpc package:
The text was updated successfully, but these errors were encountered: