Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFC I2C+ 2k broken #238

Open
Helios343 opened this issue Sep 28, 2024 · 4 comments
Open

NFC I2C+ 2k broken #238

Helios343 opened this issue Sep 28, 2024 · 4 comments
Labels
bugfix Something isn't working needs-more-info Requires more information to triage

Comments

@Helios343
Copy link

Describe the bug.

Since updating from c0d8659 to fb4d003 my previously saved nfc i2c+ 2k reads no longer let me open info on them crashing 'out of memory' everytime, I've tried also to re-read the tags and it reads as ntag203 and data is all wrong reinstalled firmware still the same, reverted back to c0d8659 and reads fine and works normally

Reproduction

Newest dev-release
https://github.com/user-attachments/assets/4635831d-830e-4a6e-b1ba-e047b4adf14e

Target

NFC I2C+ 2k

Logs

No response

Anything else?

No response

@Willy-JL
Copy link
Member

Willy-JL commented Oct 1, 2024

The recent dev builds include recent PR #237 which parses I2C+ tags as NDEF too. Either the card contains too much data to display, or there is a bug in the NDEF parser. Kindly send a copy of the nfc dump for the card, as read on firmware that doesn't crash.

@Willy-JL Willy-JL added bugfix Something isn't working needs-more-info Requires more information to triage labels Oct 1, 2024
@Willy-JL
Copy link
Member

Willy-JL commented Oct 24, 2024

@Helios343 can you try on latest devbuild? #265 made many improvements to ndef parsing. though admittedly im not sure if that tag even has ndef, but it does sound related

@Willy-JL
Copy link
Member

for what its worth, i opened the previously read file with the new ndef parser from devbuild and it shows a bunch of ndef data, but it curiously has a wrong string length value. it has a very long string, and its last character is 0xFE which is the ndef TLV terminator. so the string length should have been 1 less, since the TLV is supposed to be outside of it. or maybe they duplicated the 0xFE TLV terminator for some reason. seems off because the rest of this string seems like plain text, but since the last character is 0xFE which is not a printable character, it prints everything as hex instead of as text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something isn't working needs-more-info Requires more information to triage
Projects
None yet
Development

No branches or pull requests

2 participants