fix(istio-alerts): revert to native raw metrics (#314)

Co-authored-by: Matt Wise <[email protected]>
Nextdoor · Jun 13, 2024 · 2b16721 · 2b16721
1 parent 919760f
commit 2b16721
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/charts/istio-alerts/Chart.yaml b/charts/istio-alerts/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: istio-alerts
 description: A Helm chart that provisions a series of alerts for istio VirtualServices
 type: application
-version: 0.5.1
+version: 0.5.2
 maintainers:
   - name: diranged
     email: [email protected]

diff --git a/charts/istio-alerts/README.md b/charts/istio-alerts/README.md
@@ -1,6 +1,6 @@
 # istio-alerts
 
-![Version: 0.5.1](https://img.shields.io/badge/Version-0.5.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
+![Version: 0.5.2](https://img.shields.io/badge/Version-0.5.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
 
 A Helm chart that provisions a series of alerts for istio VirtualServices
 

diff --git a/charts/istio-alerts/templates/service-prometheusrule.yaml b/charts/istio-alerts/templates/service-prometheusrule.yaml
@@ -26,16 +26,16 @@ spec:
           in namespace {{`{{$labels.namespace}}`}}.
       expr: >
         sum by ({{- $http5XXMonitorGroupingLabelString -}}) (
-          istio_requests_increase5m{
+          rate(istio_requests_total{
             response_code=~"5.*",
             {{- $destinationServiceSelectorForIstioMetrics -}}
-          }
+          }[5m])
         )
           /
         sum by ({{- $http5XXMonitorGroupingLabelString -}}) (
-          istio_requests_increase5m{
+          rate(istio_requests_total{
             {{- $destinationServiceSelectorForIstioMetrics -}}
-          }
+          }[5m])
         )
           > {{ .threshold }}
       for: {{ .for }}