fix(charts/daemonset-app): Remove default probes (#243)

* Removing default probes * Update version * Change to null * Update version and docs * Update version and docs * Update version and docs
Nextdoor · Nov 21, 2023 · bf6a482 · bf6a482
1 parent 1002b81
commit bf6a482
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 11 deletions.
diff --git a/charts/daemonset-app/Chart.yaml b/charts/daemonset-app/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: daemonset-app
 description: Default DaemonSet Helm Chart
 type: application
-version: 0.13.0
+version: 0.14.0
 appVersion: latest
 maintainers:
   - name: diranged

diff --git a/charts/daemonset-app/README.md b/charts/daemonset-app/README.md
@@ -2,7 +2,7 @@
 
 Default DaemonSet Helm Chart
 
-![Version: 0.13.0](https://img.shields.io/badge/Version-0.13.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: latest](https://img.shields.io/badge/AppVersion-latest-informational?style=flat-square)
+![Version: 0.14.0](https://img.shields.io/badge/Version-0.14.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: latest](https://img.shields.io/badge/AppVersion-latest-informational?style=flat-square)
 
 [statefulsets]: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/
 [hpa]: https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/
@@ -13,6 +13,12 @@ ServiceAccounts, Services, etc.
 
 ## Upgrade Notes
 
+### 0.13.0 -> 0.14.x
+
+**BREAKING: Bugfix removing the default readiness and liveness probes **
+
+Removing the default readiness and liveness probes due to conflicts with custom defined ones.
+
 ### 0.10.x -> 0.11.x
 
 **NEW: Optional sidecar and init containers**

diff --git a/charts/daemonset-app/README.md.gotmpl b/charts/daemonset-app/README.md.gotmpl
@@ -12,6 +12,12 @@ ServiceAccounts, Services, etc.
 
 ## Upgrade Notes
 
+### 0.13.0 -> 0.14.x
+
+**BREAKING: Bugfix removing the default readiness and liveness probes **
+
+Removing the default readiness and liveness probes due to conflicts with custom defined ones.
+
 ### 0.10.x -> 0.11.x
 
 **NEW: Optional sidecar and init containers**

diff --git a/charts/daemonset-app/values.yaml b/charts/daemonset-app/values.yaml
@@ -98,23 +98,17 @@ volumes: []
 # -- A PodSpec container "startupProbe" configuration object. Note that this
 # startupProbe will be applied to the proxySidecar container instead if that
 # is enabled.
-startupProbe:
+startupProbe: null
 
 # -- A PodSpec container "livenessProbe" configuration object. Note that this
 # livenessProbe will be applied to the proxySidecar container instead if that
 # is enabled.
-livenessProbe:
-  httpGet:
-    path: /
-    port: http
+livenessProbe: null
 
 # -- A PodSpec container "readinessProbe" configuration object. Note that this
 # readinessProbe will be applied to the proxySidecar container instead if that
 # is enabled.
-readinessProbe:
-  httpGet:
-    path: /
-    port: http
+readinessProbe: null
 
 # -- A list of Port objects that are exposed by the service. These ports are
 # applied to the main container, or the proxySidecar container (if enabled).