feat(simple-app): only require readinessProbe when virtaulService is …

…enabled (#319)
Nextdoor · Jul 18, 2024 · fdcc31c · fdcc31c
1 parent 41c5725
commit fdcc31c
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 3 deletions.
diff --git a/charts/simple-app/Chart.yaml b/charts/simple-app/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: simple-app
 description: Default Microservice Helm Chart
 type: application
-version: 1.8.2
+version: 1.9.0
 appVersion: latest
 maintainers:
   - name: diranged

diff --git a/charts/simple-app/README.md b/charts/simple-app/README.md
@@ -2,7 +2,7 @@
 
 Default Microservice Helm Chart
 
-![Version: 1.8.2](https://img.shields.io/badge/Version-1.8.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: latest](https://img.shields.io/badge/AppVersion-latest-informational?style=flat-square)
+![Version: 1.9.0](https://img.shields.io/badge/Version-1.9.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: latest](https://img.shields.io/badge/AppVersion-latest-informational?style=flat-square)
 
 [deployments]: https://kubernetes.io/docs/concepts/workloads/controllers/deployment/
 [hpa]: https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/
@@ -13,6 +13,11 @@ defaults for you like the Kubernetes [Horizontal Pod Autoscaler][hpa].
 
 ## Upgrade Notes
 
+### 1.8.x -> 1.9.x
+
+`readinessProbe` is now only required when `virtualService.enabled` is `true`. This
+provides the flexibility to use this chart for non request serving services.
+
 ### 1.6.x -> 1.7.x
 
 **BREAKING: Istio Alerts have changed**

diff --git a/charts/simple-app/README.md.gotmpl b/charts/simple-app/README.md.gotmpl
@@ -12,6 +12,11 @@ defaults for you like the Kubernetes [Horizontal Pod Autoscaler][hpa].
 
 ## Upgrade Notes
 
+### 1.8.x -> 1.9.x
+
+`readinessProbe` is now only required when `virtualService.enabled` is `true`. This
+provides the flexibility to use this chart for non request serving services.
+
 ### 1.6.x -> 1.7.x
 
 **BREAKING: Istio Alerts have changed**

diff --git a/charts/simple-app/templates/deployment.yaml b/charts/simple-app/templates/deployment.yaml
@@ -24,7 +24,10 @@ through $deploymentZones
 {{- /*
 Verify that some required inputs are supplied
 */}}
+
+{{- if .Values.virtualService.enabled }}
 {{- $readinessProbe := required "readinessProbe is required" .Values.readinessProbe }}
+{{- end }}
 
 {{- /*
 By default, we do run the topology spread function - letting it decide
@@ -294,8 +297,10 @@ spec:
           livenessProbe:
             {{- tpl (toYaml .) $ | nindent 12 }}
           {{- end }}
+          {{- with $.Values.readinessProbe }}
           readinessProbe:
-            {{- tpl (toYaml $.Values.readinessProbe) $ | nindent 12 }}
+            {{- tpl (toYaml . ) $ | nindent 12 }}
+          {{- end }}
 
 ---