-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ascending volume to medium instead of maximum #3297
Ascending volume to medium instead of maximum #3297
Conversation
If we create too many sub pages (too much hierarchy), it could make things worse as far as helping user find what they are looking for. So, we should not overdo it. Here, I am only placing settings on a sub page that should not be needed by anyone on a daily basis. These are settings that most users spend some time tweaking until they are happy and hopefully after that, they never touch them again. Secondly, the settings that are placed on the same subpage are either dependent on each other, or are strongly related to each other. |
Merge remote-tracking branch 'Navid200/Navid_2024_01_19' into schubi
I have added the option to ascend to medium instead of maximum if the ascending volume profile is selected. Enabling the new setting does not change the slope. So, the ascending speed is not change. Only the value is clamped at the medium level if the new setting is enabled. |
I have tested this by monitoring the detail logs and verifying that the volume goes through the expected steps in both cases when the setting is enabled or not. |
The request for this has been made by someone who may occasionally take a while to walk to the phone to snooze the alert. When I planned this, I could have taken two different approaches. |
This is what we have now in the guide: https://navid200.github.io/xDrip/docs/Ascending-volume-profile.html If this is approved, this is the image I am currently working on just to give you a better idea how the new setting behaves. The draft marker of course will be removed when it is done. And I am still working on it. I am not sure about the guide details yet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable
Edit (April 11, 2024):
This is now about more than just adding 3 subpages. It now also adds the new setting to allow ascending volume profile to ascend to medium instead of high.
This PR creates 3 subpages on the Glucose Alert Settings page.
There are already many settings on the page. I would like to add one more. There will be too many settings.
Grouping the settings such that settings that are strongly tied together on the same subpage would allow us to reduce the number of settings while allowing the user to easily find the settings they need.