-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Statistics Customization 1 #3707
Open
Navid200
wants to merge
4
commits into
NightscoutFoundation:master
Choose a base branch
from
Navid200:Navid_2023_08_18
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What are the default set of statistics which will be visible? Is this currently inside a Scrollview? If not would it be better if it were? |
StatsParams.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to choose which items you would like to see on the statistics distribution page.
After this PR, you will only be able to remove some of the existing items.
If this is approved, we already have an open PR for adding capture rate. I will work on that to add that to the menu and give credit to the person opening that PR.
Later, I would also like to add very high and very low.
Changing the pie chart to a bar chart as you requested will come later.
I chose using a simple menu so that after closing the menu, you will still be on the statistics page instead of going to the main screen.
I have avoided adding any strings so that we can make sure we are happy with English before any translation work starts.
So, why do we need this?
This is not a bug fix. I think it can be useful. The distribution page is already very cluttered and we have an open PR to add yet one more item to it. This will allow one to remove what they don't need to clean up the page as they wish.
Please let me know what you think.