Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reexport kira #73

Closed
harudagondi opened this issue Sep 4, 2022 · 2 comments · Fixed by #86
Closed

Reexport kira #73

harudagondi opened this issue Sep 4, 2022 · 2 comments · Fixed by #86

Comments

@harudagondi
Copy link
Contributor

Currently, to create a StaticSoundData for AudioSource, you have to import kira with the correct version. I'd like... to not do that lol.

Also, in the case that #63 would be implemented, it is likely that users would have to reimport kira just to implement their own SoundData.

A solution to this is to reexport kira itself.
@NiklasEi
Copy link
Owner

NiklasEi commented Sep 9, 2022

Not sure about reexporting Kira here. I would prefer to keep the API backend agnostic. For #63 there will likely be a new trait from bevy_kira_audio. We could do the same for StaticSoundData.
Would that be fine?

@harudagondi
Copy link
Contributor Author

I think reexporting StaticSoundData, SoundData, and Sound would be fine. However, when a new type from kira is used in the public api, then it should also be exported.

Is there a way for Github Actions to know that a foreign item is used, but not reexported?

@NiklasEi NiklasEi mentioned this issue Mar 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reexport used Kira types NiklasEi/bevy_kira_audio
2 participants
@NiklasEi @harudagondi