-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend NsdServiceInfo to include ipv4 and ipv6 #22
Comments
How to use 1.4.0 version? And where I can find IP. Thanks |
This isn't implemented yet. 1.4.0 hasn't been released. |
should we close this issue and open a new one for the missing iOS implementation? |
an iOS fix should be pretty straightforward as the NetService class also includes an array of addresses: var addresses: [Data]?
However it seems that that entire class has been deprecated so an overall refresh may be needed anyways. |
yes, let's close and open a new one for iOS and MacOS 👍 |
BTW what is your opinion - I was debating with myself. Currently I return a List containing the addresses in string representation. I could also have chosen to return a List. But Strings can be easily converted to InternetAddress and vice versa. On the other hand it seemed that String was the most straightforward way to return the addresses from the platform interface. And at least for Windows there was no other option. |
I think it was a good choice 👍 |
As discussed in #19, currently
hostname
can be an IP address. It would be better to introduce new fields for storing ipv4 and ipv6. This affects all supported platforms (iOS, MacOS, Android and Windows).The text was updated successfully, but these errors were encountered: