Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hackage-db: signatures field in MetaData has the wrong type #573

Open
michaelpj opened this issue Apr 6, 2022 · 0 comments · May be fixed by #575
Open

hackage-db: signatures field in MetaData has the wrong type #573

michaelpj opened this issue Apr 6, 2022 · 0 comments · May be fixed by #575

Comments

@michaelpj
Copy link

It's not a list of strings, it's a list of structured objects. They look like this:

{
  "keyid":"90a6b6d70ee8a2467cdacfc42a6ae2b22d4676b240210881b32a9eb55ecc8e58",
  "method":"ed25519",
  "sig":"K4nOQyuRq0JmbsdevazQWHzmQ0YtxCOXaFqi3kdnHipZXIy/G15RNPGJhhK0iMfPaW57PzrTj6foZJAZNxMYAw=="
}

I'll make a patch.
michaelpj referenced this issue in michaelpj/hackage-db Apr 6, 2022
@michaelpj
Fix the type of signatures in metadata
8a2300e 
Signatures are actually complex objects. We could use `Value` here since
it's unlikely that any consumers care about this, but it's cheap enough
to just define a structure for the signature objects.

In practice this isn't an issue because it seems like this field is
never populated in Hackage, but it can be populated if you build a
custom Hackage it can happen.

Fixes #16.
@michaelpj michaelpj mentioned this issue Apr 6, 2022
Closed
@sternenseemann sternenseemann transferred this issue from NixOS/hackage-db Oct 10, 2022
@sternenseemann sternenseemann changed the title signatures field in MetaData has the wrong type hackage-db: signatures field in MetaData has the wrong type Oct 10, 2022
sternenseemann pushed a commit that referenced this issue Oct 10, 2022
@michaelpj @sternenseemann
Fix the type of signatures in metadata
4262a32 
Signatures are actually complex objects. We could use `Value` here since
it's unlikely that any consumers care about this, but it's cheap enough
to just define a structure for the signature objects.

In practice this isn't an issue because it seems like this field is
never populated in Hackage, but it can be populated if you build a
custom Hackage it can happen.

Fixes #573.
@sternenseemann sternenseemann linked a pull request Oct 10, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@michaelpj