Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCons: Add patch for aarch64-darwin #346207

Closed
wants to merge 1 commit into from

Conversation

hummeltech
Copy link
Contributor

@hummeltech hummeltech commented Oct 3, 2024

SCons fails on Darwin (aarch64 specifically) in a sandboxed environment.

SCons/scons@2d5e3a4

On Darwin, Nix may invoke SCons in a sandbox which lacks access to
/etc/paths.d. Handle PermissionError while iterating through
/etc/paths.d to support sandboxed environments such as Nix.

E.g. while building mapnik (more details here):
image

Things done

Added upstream patch to fix SCons failures on aarch64-darwin

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@hummeltech hummeltech force-pushed the SConsDarwinEtcPathsD branch from 9fc3d44 to d9109f5 Compare October 3, 2024 17:44
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 3, 2024
@superherointj
Copy link
Contributor

This likely needs to target staging.

@ofborg ofborg bot requested a review from AndersonTorres October 3, 2024 19:16
@fabianhjr fabianhjr marked this pull request as draft October 3, 2024 19:37
@fabianhjr fabianhjr changed the base branch from master to staging October 3, 2024 19:37
@fabianhjr fabianhjr marked this pull request as ready for review October 3, 2024 19:37
@fabianhjr
Copy link
Member

Hi @hummeltech, thanks for contributing.

Due to the number of rebuilds this needs to target the staging branch. There seems to be a merge conflict after changing the base.

Reference: https://github.com/NixOS/nixpkgs/blob/nixos-24.05/CONTRIBUTING.md#staging

@hummeltech
Copy link
Contributor Author

Good idea, this already appears to have been addressed in staging, thanks for the help!

@hummeltech hummeltech closed this Oct 3, 2024
@hummeltech hummeltech deleted the SConsDarwinEtcPathsD branch October 3, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants