-
-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vtk: switch to new sdk pattern on darwin #358790
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
tricktron
added
0.kind: ZHF Fixes
Fixes during the Zero Hydra Failures (ZHF) campaign
backport release-24.11
Backport PR automatically
labels
Nov 24, 2024
tricktron
force-pushed
the
switch-vtk-to-new-sdk-pattern
branch
from
November 25, 2024 06:35
dc81df5
to
6e60b1d
Compare
emilazy
reviewed
Nov 25, 2024
wegank
force-pushed
the
switch-vtk-to-new-sdk-pattern
branch
from
November 25, 2024 20:57
6e60b1d
to
71fbdd8
Compare
emilazy
approved these changes
Nov 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely clean‐up, thank you!
@wegank Thank you for stepping in and cleaning up the last bit! |
ofborg
bot
added
10.rebuild-darwin: 11-100
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux
labels
Nov 26, 2024
wegank
added
the
12.approvals: 1
This PR was reviewed and approved by one reputable person
label
Nov 26, 2024
Successfully created backport PR for |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
0.kind: ZHF Fixes
Fixes during the Zero Hydra Failures (ZHF) campaign
6.topic: darwin
Running or building packages on Darwin
10.rebuild-darwin: 11-100
10.rebuild-linux: 0
This PR does not cause any packages to rebuild on Linux
12.approvals: 1
This PR was reviewed and approved by one reputable person
backport release-24.11
Backport PR automatically
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Switch vtk to the sdk-pattern on darwin. The main reason was to fix gdcm as part of ZHF which it does.
However, this might break other packages, so a thorough review is needed.
Needs 24.11 backport for ZHF #ZurichZHF
ZHF: #352882
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.