-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add badge to os icon and profilist icon per profile #18
Comments
WinXPLast Updated June 22, 2014Progress 83%
|
Win7Last Updated Jan 30, 2015Progress 100%
|
Notes on setting icon in Mac:
notes from irc:
|
For Linux check out:
edit: dec 9 14 |
### bootstrap.js * setup badging (for profilist menu items, not on OS icon yet) (Address Issue #18) * Profilist.badge is written to ini and dom is updated based on it * fixed some [i] errors on ppRemoved and ppAdded * also some ppRemoved and ppAdded were at ppChanged which was a bug ### main.css * styling for when click on badge to change it
LinuxLast Updated Apr 17, 2015Progress 67%
Check out Bugzilla :: Bug 595462 - patch v1, load window icons from everywhere/from all supported formats which uses GDK to change icons. From Bugzilla :: Bug 595462 - Support loading window icons from zips, thanks to @nmaier telling me about it here: GitHubGIST :: Noitidart / _ff-addon-snippet-ChangeWindowIcon.js - Comment 4 |
* Addressing issue #18 * On startup now applying the proper icon (if not pinned there is a couple seconds of lag for the icon to kick in as startup of browser takes place) * Previous rev implemented applying icon from badge selection process (by clicking on activity icon in Profilist menu) but it did not set it on the right profile, it would set on current profile, still working on targetting profile thats running but not itself
* Working on making icon change affect right profile in WINNT for Issue #18 * Right profile is getting targeted but something is up with jscGetDeepest when it writes to file it its weird
* More work for Issue #18 for Windows * It works on setting icon foreign pid * Added test for if WinXP and it it does LoadImage properly * Need to make it not update profile if Profilist is not installed on it though * Need to give the pinned icon change support for Win7+
* Continuing on issues for #18 on WINNT * SystemAppUserModelId on shortcuts now works, i found out that if it already exists you cannot update it, it will throw access denied. so that id can only be set if it the file doesnt exist
Now updating pinned shortcuts for Win7+ for Issue #18
Commits 1.2.rev175-177 focused on landing desktop shortcut creation (with proper icon) for Windows but they were just commits to save. This one lands it, tested it a little, should test more. So related to Issue #18.
For Issue #18 for WINNT made sure to set RelaunchIcon Resource Command after picker set. Change so getPtrStrToWinOfProf now takes 3rd argument of visWin and it only collects window is visible. I think this is feesbile because im assuming overhead to check style of window is minimal compared to getting all windows and doing IPropertyStore on each and even just setting icon on each window (there are like 5 non-vis win for each vis win, so thats 5 extra bogus overhead)
Any way I can play with this? I see a 2.0 branch, but I don't know how to package properly :) |
Hey @evacchi sorry about that I got hung up with some other stuff. Let me get you the mac version its on my VM somewhere. v2.0 doesnt have the mac part merged in yet but your question motivates me to do it. |
@evacchi you can grab the xpi from: https://github.com/Noitidart/Profilist/tree/mac-iconing-alpha the one named " Porfilist 2 alpha mac iconing.xpi". To make the icon, click on main menu, then hover over profilist stack, it expands, then mouse over the imaf of the "user" (black/transparent) to the left of the profile name. Then click it, then select image or images (multi sizes of same image) to use as badge. then its badged. you can now go the options page, and then click "create shortcut" and choose the profile name. however an issue i havent figure out yet is that when running in the badged version, firefox updates seem to fail. |
uhm, which version of FFox should I be using? The file picker is shown, but when I pick a picture (png, jpg) no icon is shown -- and the generated files seems to be 0 bytes |
Oh crap I just tested it you're right. Ok let me see whats going on Ill update you. |
Fixed it @evacchi thanks for that note. It was due to a chance in Firefox 37 where array buffers were neutered: https://github.com/Noitidart/Profilist/tree/mac-iconing-alpha same xpi so after you badge the icon from the menu, then go to preferences, and create desktop shortcut, then launch the profile from there. if you change the badge multiple times i have an issue where the desktop alias icon is not updating visually, but if you do get get info on it, you will see the icon is updated. the issue i brought up here: http://apple.stackexchange.com/questions/174761/make-alias-take-icon-of-the-app-it-points-to?noredirect=1#comment205991_174761 To work around it you can rename the alias to something new i dont know why this fixes it. So anyways, you don't have to force the icon to take, you can drag that icon to dock, or just launch it, keep in dock on restart etc etc, it will show the updated icon everywhere except the dang desktop. :) |
If icons dont update, you have to open terminal and do Or you dont have to |
@evacchi how did it work out for you? |
@evacchi I created and released an addon that allows you to provide png(s) for base and png(s) for badge and it will create a ICNS for you check it out: https://addons.mozilla.org/en-US/firefox/addon/icon-container-generator/ |
ha! that's neat. so if I got it right:
This approach does work, but I though you had found a way to avoid creating the launcher in the first place, by badging the firefox icon "on the fly"; this can be easily done with a text label (as I did with my small addon), but I'm not sure about an arbitrary icon. The point of my addon was to avoid creating the desktop alias :) BTW, still props for the effort! |
@evacchi :) The on fly thing works but it has major quirks. You cannot right click on the icon and keep in dock. It will think it is the main profile. If you have it running, and shutdown your computer, and told it to restart with last open programs, it will open with main profile. So I had to make the alias :( But you can use this addon to set it on the fly: https://github.com/Noitidart/Firefox-on-OS-X-Icon And correct, I didn't hook up the buttons in the toolbar to launch the profile yet in that version. Launching from that alias is the only way. :( I have a hidden one, so in the non-alpha, it launches that hidden one, so a desktop alias is not required, but in this alpha version this parts not setup. |
@evacchi updated in a huge way, this is true beta version - https://addons.mozilla.org/en-US/firefox/addon/profilist/versions/beta Its in beta until I can get a patch in on Firefox. As on Mac the update mechansim is broken on profiles launched from Profilist menu, or by desktop launchers created by Profilist. |
Credits to evacchi for the beautiful idea: evacchi/firefox-custom-badge#1
The text was updated successfully, but these errors were encountered: