Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll support? #30

Open
saiworksandbox opened this issue Jul 14, 2023 · 6 comments
Open

Scroll support? #30

saiworksandbox opened this issue Jul 14, 2023 · 6 comments

Comments

@saiworksandbox
Copy link

When there are a lot of reactions the list view gets cut off. And the rest can be viewed only at the bottom of the page.
Screenshot (2)
It would be great if we could scroll through this.
Thank you for such a useful extension 👌

@Norfeldt
Copy link
Owner

The problem is that it is "sticky" and I'm wondering if you would be better off with a filter/threshold (top x most rated reactions)?

@saiworksandbox
Copy link
Author

saiworksandbox commented Jul 18, 2023

what are your thoughts on having pages? with arrow icons for navigation. Often times I find myself looking for reactions (even if few) on the bottom of the page as that's where the latest info is.
Filtering is certainly a cleaner solution though.

@Norfeldt
Copy link
Owner

I never personally had the problem. If I did then I would just toggle the layout from block(s) to inline.

Jul-19-2023 20-36-24

I'm not saying that it not a real problem. I want to find the correct solution to the problem before jumping into the code.

@Norfeldt
Copy link
Owner

a hack would be update the .reaction-wrapper to include:

height: 85vh;
overflow: auto;

It just feels like it messes with the page scroll since it common to place your cursor above the reactions and start scrolling.

@saiworksandbox
Copy link
Author

saiworksandbox commented Jul 20, 2023

Its certainly an edge case when even the inline mode gets cut off. Maybe a toggle to reverse the order of the reactions? so that reactions on the latest comments show up first?

@Norfeldt
Copy link
Owner

Or have a toggle for the position: sticky 😉

I suggest you either make a PR. Otherwise I will wait to see if this issue gets some 👍 from other users and then make the feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants