Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple re-draw the Reactions part #35

Open
reply2future opened this issue Sep 12, 2024 · 0 comments
Open

Multiple re-draw the Reactions part #35

reply2future opened this issue Sep 12, 2024 · 0 comments

Comments

@reply2future
Copy link

Problem

When the github issue page is loading, the extension will invoke the addReactionNav function around 55 times! We should update only when document is ready status.

Re-production

add console.log('invoke addReactionNav') to the start of addReactionNav function, then load the github issue page, and you would look that message
image
reply2future added a commit to reply2future/github-issue-reactions-browser-extension that referenced this issue Sep 12, 2024
@reply2future
perf(loading): avoid to invoke addReactionNav function multiple tim…
f50da95 
…es when page is loading

re Norfeldt#35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@reply2future