Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #25742: Add LDAP synchronous mode config param #5967

Closed
wants to merge 1 commit into from
Closed

Fixes #25742: Add LDAP synchronous mode config param #5967

wants to merge 1 commit into from
+112 −68

Conversation

fanf
Copy link
Member

@fanf fanf commented Oct 25, 2024 •
edited
Loading

https://issues.rudder.io/issues/25742

Make LDAP request synchronous by default (configurable via a rudder properties parameter).
This make async request impossible (ie when we query LDAP with a listener and then asked for answers), but we don't use any of them (AFAIK).
Making request synchronous make the pool usage more predictable, error more clearly linked to the request leading to them, and general enhance performance.
See https://ldapwiki.com/wiki/Wiki.jsp?page=Tips%20using%20UnboundID%20LDAP%20SDK#section-Tips+using+UnboundID+LDAP+SDK-LDAPConnectionPoolsAndGetConnection

Also add options to:

  • release the connection to the pool as early as possible in case of error,
  • use information from our LDAP Schema and don't try to refresh them (since in Rudder, the schema doesn't change without a restart of Rudder)

@fanf fanf requested a review from ncharles October 25, 2024 16:51
clarktsiory
clarktsiory reviewed Nov 20, 2024
View reviewed changes
Copy link
Contributor

@clarktsiory clarktsiory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it should be merged after the current release patch in preparation, marking this as "can't merge"

@fanf
Copy link
Member Author

fanf commented Nov 27, 2024

Replaced by #6045

@fanf fanf closed this Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarktsiory clarktsiory clarktsiory left review comments

@ncharles ncharles Awaiting requested review from ncharles

@VinceMacBuche VinceMacBuche Awaiting requested review from VinceMacBuche

Assignees
No one assigned
Labels
qa: Can't merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fanf @clarktsiory