Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Sources/Targets #6

Open
helje5 opened this issue Nov 4, 2016 · 0 comments
Open

Drop Sources/Targets #6

helje5 opened this issue Nov 4, 2016 · 0 comments

Comments

@helje5
Copy link
Member

helje5 commented Nov 4, 2016

Noze.io has the concept of streams (GReadableStream, GWritableStream) and generators/sinks (GReadableSourceType, GReadableTargetType). The latter just read and write items while the former provide a buffer and all the event and piping logic.

That separation of concerns seems actually quite good, but also makes the solution quite a bit more complex and adds an extra layer of callback closures.
So in retrospective I think we should rather remove them and just have streams with the relevant logic embedded in subclasses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant