Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ubl_template picking, always return DeliveredQuantity #1065

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

Fix ubl_template picking, always return DeliveredQuantity #1065

wants to merge 1 commit into from
+34 −11

Conversation

cyrilmanuel
Copy link

@cyrilmanuel cyrilmanuel commented Nov 14, 2024 •
edited
Loading

The block for t-if="line.Mngs_Mng" return false in case of the value is 0.0 that mean you will not see the block as result for values set to 0.0.

adding test with entry set to 0.0 as qty

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

jbaudoux
jbaudoux suggested changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will also need to remove the blank line in wamas/tests/samples/WAMAS2UBL-SAMPLE_AUSKQ_WATEKQ_WATEPQ-DESPATCH_ADVICE.xml

  		</cbc:DeliveredQuantity>
- 		
  		<cac:OrderLineReference>

base_wamas_ubl/lib/wamas/ubl_template/picking.xml Outdated Show resolved Hide resolved
@cyrilmanuel cyrilmanuel force-pushed the fix-template-deliveredquantity branch 2 times, most recently from 2dbda9d to 687997f Compare November 20, 2024 07:03
jbaudoux
jbaudoux approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, like that :)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santostelmo santostelmo santostelmo approved these changes

@simahawk simahawk simahawk left review comments

@Ricardoalso Ricardoalso Ricardoalso approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@cyrilmanuel @OCA-git-bot @simahawk @jbaudoux @santostelmo @Ricardoalso