Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] stock_release_channel_propagate_channel_picking: Propagate when assigning too #908

Open
wants to merge 2 commits into
base: 16.0
Choose a base branch
from

Conversation

rousseldenis
Copy link
Contributor

As internal pickings could have generated a backorder and outgoing picking too without unrelease (e.g.: long term channels - no sleep), the channel is void on those internal backorders. So, at outgoing picking channel assignation, propagate the channel to the still existing origin pickings.

… assigning too

As internal pickings could have generated a backorder and outgoing picking too without
unrelease (e.g.: long term channels - no sleep), the channel is void on those internal backorders.
So, at outgoing picking channel assignation, propagate the channel to the still existing origin
pickings.
@rousseldenis rousseldenis marked this pull request as draft June 5, 2024 14:21
@rousseldenis rousseldenis marked this pull request as ready for review June 11, 2024 12:01
@rousseldenis rousseldenis added enhancement New feature or request needs review labels Jun 11, 2024
@rousseldenis rousseldenis added this to the 16.0 milestone Jun 11, 2024
Copy link
Contributor

@sebalix sebalix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link
Contributor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (Code review)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Contributor

@jbaudoux jbaudoux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you drop changes to OCA generated files?

@rousseldenis
Copy link
Contributor Author

Can you drop changes to OCA generated files?

Will be hard. But that does not bother as these changes reflect also changes of the module.

@jbaudoux
Copy link
Contributor

jbaudoux commented Oct 7, 2024

Can you drop changes to OCA generated files?

Will be hard. But that does not bother as these changes reflect also changes of the module.

@rousseldenis It's annoying when porting the commits to other version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants