Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

network parameter: file type #3

Open
bertsky opened this issue Mar 1, 2023 · 2 comments
Open

network parameter: file type #3

bertsky opened this issue Mar 1, 2023 · 2 comments

Comments

@bertsky
Copy link
Contributor

bertsky commented Mar 1, 2023

https://github.com/MegaloPat/ocrd_froc/blob/4c207eb708235bf6a7696e6feed62630e08c20b1/ocrd_froc/ocrd-tool.json#L25

According to our convention for file resources, this should additionally have format=uri cacheable=True and some content-type (not sure what .froc suits best).
@GemCarr
Copy link
Collaborator

GemCarr commented Mar 1, 2023 •
edited
Loading

maybe typegroups-classifier should be changed as well then ? (it comes from there)

@GemCarr GemCarr closed this as completed Mar 1, 2023
@GemCarr GemCarr reopened this Mar 1, 2023
@bertsky
Copy link
Contributor Author

bertsky commented Mar 1, 2023

maybe typegroups-classifier should be changed as well then ? (it comes from there)

yes, that would be ideal.

(It's not pressing because you ship the models along with the code, though.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bertsky @GemCarr