ID labels are not consistent in SVG files

[StephanSiemen]

We would like to use the SVG symbols by a unique ID, but unfortunately some labels are wrongly labeled.

[tomkralidis]

@StephanSiemen thanks for reporting. Can you provide some examples so I can reproduce?

[StephanSiemen]

Tom,

Actually, I corrected most files already on in my branch of the cloned
repository. How could I push my branch back to GitHub that I can file a
pull request? I have an account, but I seem not to have permission to push
to the repository?!

Thanks
Stephan

On 12 June 2015 at 13:41, Tom Kralidis [email protected] wrote:

@StephanSiemen https://github.com/StephanSiemen thanks for reporting.
Can you provide some examples so I can reproduce?

—
Reply to this email directly or view it on GitHub
#35 (comment)
.

[tomkralidis]

Hi @StephanSiemen. The best approach here is to:

• fork the repository into your user space, and clone your fork
• copy the changes into your fork
• commit the changes with your fork
• push the committed changes to your fork on GitHub
• open a Pull Request on GitHub

So something like:

# fork repository on GitHub
git clone https://github.com/StephanSiemen/WorldWeatherSymbols.git
# copy earlier changes (wherever they are) into your fork
git commit -am 'fix ID labels (#35)'
git push origin master
# create New Pull request on GitHub

[chris-little]

Stephan,

As Tom suggested, can you supply some examples please?

There is only a partial mapping to the WMO codes, as some signs have alternates, or are determined by other means (such as Synop 8 groups!)

Consequently, you will see Ids like 97, 97a, 97b, so it is not one-to-one.

I agree unique Ids are required, but thought that I had supplied them. The intent is to use these to index into the populated WMO registries.

Chris

From: Tom Kralidis [mailto:[email protected]]
Sent: Friday, June 12, 2015 1:41 PM
To: OGCMetOceanDWG/WorldWeatherSymbols
Subject: Re: [WorldWeatherSymbols] ID labels are not consistent in SVG files (#35)

@StephanSiemenhttps://github.com/StephanSiemen thanks for reporting. Can you provide some examples so I can reproduce?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/35#issuecomment-111478263.

[chris-little]

@tomkralidis Stephan has now moved on from ECMWF, and I never saw a PR. So the question is, as the WMO registers do not seem fully populated, whether the IDs that were created have a good syntax for a URI environment, and how will WMO handle those weather symbols that have a many-to-one mapping onto the WMO weather codes.