Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'print friendly' long text of subgroup name, force default name #135

Open
chrisknoll opened this issue Apr 10, 2024 · 1 comment
Open
Milestone

Comments

@chrisknoll
Copy link

chrisknoll commented Apr 10, 2024

The current implementation of a subgroup name from cohort subset definition is to create a long title based on cohortID, the start end windows, and other attributes. This leads to extremely long titles that actually don't have 'searchable' text.

Example: you made a subset def to find prior Hypertension within 30d. That should be the subgruop name: 'prior hypertension within 30d'. Or even just 'prior hypertension' if the days do not need to be displayed in the name.

There was a feature added to override the default behavior with putting the fully specified subgroup def in the name. This issue is to remove that behavior (tho, creating a descritpion of the subgroup is something that is useful, just not for use in naming the cohort). Ie: we should never have the print friendly text used as the default cohort name for the subgroup.

To illustrate this:
image

The cohort names presented in this plot are not effective.

@anthonysena anthonysena added this to the v1.0 milestone Jun 28, 2024
@anthonysena
Copy link
Collaborator

Noting that this would be a potentially breaking change which we can plan for v1.0 and then require the use of a subset template name per #118.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants