Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cohort sample table - backwards compatibility #138

Closed
anthonysena opened this issue Apr 23, 2024 · 0 comments · Fixed by #147
Closed

Cohort sample table - backwards compatibility #138

anthonysena opened this issue Apr 23, 2024 · 0 comments · Fixed by #147
Assignees
@anthonysena
Milestone
v0.9

Comments

@anthonysena
Copy link
Collaborator

If someone had serialized the cohort table names to an external file and then attempted to call the createCohortTables, this code will fail since it will attempt to evaluate NULL && NULL:

https://github.com/OHDSI/CohortGenerator/blob/0c0e48792103beda659f9f1a57c34f0058beb7a3/R/CohortTables.R#L109C27-L110
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anthonysena anthonysena

Labels
None yet
Projects
None yet
Milestone
v0.9
Development

Successfully merging a pull request may close this issue.

Ensure sample table check is backwards compatible OHDSI/CohortGenerator
2 participants
@azimov @anthonysena