-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide configuration option to disable source connection checks #2359
Comments
@anthonysena @fdefalco I'm looking into this one and going to prepare a PR. Please, let me know in case of concerns or additional requirements. I'm going to add the flag to skip connection check both on deployment and individual data source level. Data source level setting has a precedence over deployment level. This covers simple cases and allows fine tuning with minimum effort in terms of configuration. |
Thanks @ganisimov - it is probably cleaner to just have this setting on the data source and not on the deployment. Presumably you'll have a flyway migration that adds a new column for the data source connection check and we'd have it default to "true" and then we can optionally turn it off where needed. So please ignore my suggestion of having an application-level configuration for this setting. |
* Add check_connection flag to SourceRequest Related to #2359 * Fix putting constant on left side of equality operator --------- Co-authored-by: Gennadiy Anisimov <[email protected]>
The following line of code will attempt to check the connection to a configured data source upon startup:
WebAPI/src/main/java/org/ohdsi/webapi/source/SourceService.java
Line 108 in d90d653
This is problematic for data sources, such as DataBricks, where the database server takes time to activate upon first query which results in WebAPI hanging until the DataBricks environment starts up. We'd like to be able to control this behavior through configuration - either overall for the WebAPI deployment or on an individual data source level.
The text was updated successfully, but these errors were encountered: