Bug Fix: Return correct count values for RC/DRC and PC/DPC #2405
Conversation
| <artifactId>asm</artifactId> | ||
| <version>1.0.2</version> | ||
| <scope>test</scope> | ||
| </dependency> |
There was a problem hiding this comment.
I needed to add this dependency in order to get the project to build and run in my test runner.
There was a problem hiding this comment.
should be fine, the scope is test so won't be part of the final bundle.
| List<CDMCacheEntity> zeroConcepts = idsSlice.stream().map(id -> { | ||
| List<Integer> notFoundIds = new ArrayList<Integer>(CollectionUtils.subtract(idsSlice, cachedIds)); | ||
| if (!notFoundIds.isEmpty()) { // store zeros in cache | ||
| List<CDMCacheEntity> zeroConcepts = notFoundIds.stream().map(id -> { |
There was a problem hiding this comment.
This is the bug fix (all the other files are for adding the integration test). The idsSlice variable is a subList of the ids that were passed into this method. In Java, an array subList references the parent list that it came from, and thus any structural changes to it affect the parent list. We were removing the cachedIds from slice, which also removed them from the parent ids list. After this method is called, the calling method uses the ids list to determine what to return the front end, so what was happening was that any counts we had to get from the DB were not being returned.
There was a problem hiding this comment.
Very good explanation. Thank you for researching this and providing a patch.
Closes #2296
The issue is that we were modifying an array of concept IDs when going to the DB for their counts and caching them. I wrote an integration test cover this scenario.
I had some trouble getting the integration tests to run in my environment, and ended up having to add a dependency to the pom.xml file.