Multipart mime 3487 v3 #1377
Closed
Multipart mime 3487 v3 #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix manually crafted pcaps to have valid MIME headers folding beginning with space And removing the test for BODY_BOUND which is becoming obsolete
This was referenced Sep 6, 2023
jufajardini
requested changes
Sep 7, 2023
Comment on lines
+1
to
+2
| # *** Add configuration here *** | ||
|
|
There was a problem hiding this comment.
We usually ask folks to remove this. :P
There was a problem hiding this comment.
Ok.
Why is it not removed automatically ?
There was a problem hiding this comment.
I imagine that that is so people have a hint that test.yaml can be used for some configuration settings, too?
| @@ -0,0 +1,11 @@ | |||
| # Test Description | |||
|
|
|||
| Test some mimre processing | |||
There was a problem hiding this comment.
Is mimre a real term, or is it a typo? Couldn't find it on google...
There was a problem hiding this comment.
Oops, changing
Closed
|
Replaced by #1383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/3487
See OISF/suricata#9424
#1371 with fixes to pcap
@inashivb do you approve ?