Multipart mime 3487 v4 #1383
Multipart mime 3487 v4 #1383
Conversation
|
|
||
| ## PCAP | ||
|
|
||
| Previous unit test for MIME in Suricata |
There was a problem hiding this comment.
They all say this but have a pcap within every test. Can we deduplicate it?
createst cannot do this at the moment. It copies pcap files to the test..
There was a problem hiding this comment.
These are different unit tests / pcaps...
Do I miss something ?
There was a problem hiding this comment.
I'm assuming she thought they were all the same... 🤔 maybe just some rewording.
Maybe: Adapted using data from a previous specific unit test for MIME in Suricata. ?
| @@ -0,0 +1,48 @@ | |||
| # *** Add configuration here *** | |||
There was a problem hiding this comment.
nit: These are indicators to add more conf like min version required and should/can be removed when no additional conf is needed
There was a problem hiding this comment.
ah. i see its done in the next commit. I think these fixes should be a part of this commit.
mime: fix tests for bug-6207 Fix manually crafted pcaps to have valid MIME headers folding beginning with space And removing the test for BODY_BOUND which is becoming obsolete
catenacyber
force-pushed
the
multipart-mime-3487-v4
branch
from
7892393 to
1ba81ee
Compare
|
Replaced by #1385 |
Ticket
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/3487
See OISF/suricata#9424
#1377 with review taken into account
@inashivb do you approve ?