detect-uricontent: add tests - v8 #1443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #725
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6143
Built upon @TheKharleeci work. Decided to take a different approach for
detect-uricontent-04entirely, splitting it up into 4 separate tests, since the main blocker for completion here seemed to be the fact that we weren't able to easily reproduce in a single pcap what we used to had in the 4 tests.Removed Modupe's
detect-uricontent-04test directory, for that, but new tests are based on it.If it helps with reviewing, the commit that removed the unittests in question is OISF/suricata@dc8908b2820112c157d87ae