Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

detect-proto: add a test for DNS detected as DCERPC by PM #2008

Closed
wants to merge 1 commit into from
Closed

detect-proto: add a test for DNS detected as DCERPC by PM #2008

wants to merge 1 commit into from

Conversation

ilya-bakhtin
Copy link
Contributor

a replacement of #1989

This was referenced Aug 13, 2024
Closed
Closed
@catenacyber catenacyber mentioned this pull request Aug 27, 2024
Closed
catenacyber
catenacyber approved these changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@catenacyber catenacyber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test looks good to me.

a README.md file could be added, mentioning the redmine ticket
The redmine ticket number could also be included in the commit message.

@catenacyber catenacyber added the requires suricata pr Depends on a PR in Suricata label Aug 27, 2024
@ilya-bakhtin ilya-bakhtin mentioned this pull request Aug 29, 2024
Closed
4 tasks
@inashivb
Copy link
Member

Test looks good to me.

a README.md file could be added, mentioning the redmine ticket The redmine ticket number could also be included in the commit message.

Agreed w Philippe. The test is too vague in itself although correct.
Also, a new rebased PR can show if those weird failures on main-7.0.x still exist.

@catenacyber
Copy link
Collaborator

The test is too vague

How so ?
Did you rather mean that the point of the test is not enough documented ?

@inashivb
Copy link
Member

The test is too vague

How so ? Did you rather mean that the point of the test is not enough documented ?

yes. Sorry for being unclear.

@ilya-bakhtin ilya-bakhtin mentioned this pull request Nov 19, 2024
Open
5 tasks
@ilya-bakhtin ilya-bakhtin mentioned this pull request Nov 28, 2024
Open
@catenacyber
Copy link
Collaborator

Replaced by #2151 if I am not mistaken

@catenacyber catenacyber closed this Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catenacyber catenacyber catenacyber approved these changes

Assignees
No one assigned
Labels
requires suricata pr Depends on a PR in Suricata
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilya-bakhtin @inashivb @catenacyber