Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mqtt: add additional tests for reason codes - v2 #2106

Closed
wants to merge 3 commits into from

Conversation

satta
Copy link
Contributor

@satta satta commented Oct 24, 2024

Previous PR: #2102

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/7323

Changes to previous PR:

  • Set minimum Suricata version for SUBACK test to 8.

Copy link
Contributor

@jufajardini jufajardini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me now, thanks!

One thing I'm not sure about is the forum linked in the commit message, but I'll let Victor or someone else be the judge for that.

@satta
Copy link
Contributor Author

satta commented Oct 25, 2024

One thing I'm not sure about is the forum linked in the commit message, but I'll let Victor or someone else be the judge for that.

The post is also linked in the Redmine ticket, so I could also remove it -- not sure why that would matter though :)

@victorjulien
Copy link
Member

Merged in #2118, thanks!

@satta satta deleted the 7323-mqtt-rules-v2 branch November 6, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requires suricata pr Depends on a PR in Suricata
Development

Successfully merging this pull request may close these issues.

3 participants