tests: add more filestore tests #2111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests exhibiting issue on filestore Tickets: #7346 #7347
The signature was about storing on all events of the flow. After fixing Suricata, this is really doing that. As a result the test is failing. By updating the signature to store on the tx only, we are now testing what was looking like the purpose of the test which is to only extract the file corresponding to the URL.
Make sure the result are correct with regards to filestore keyword impact.
catenacyber
added
requires suricata fix
5 tasks
5 tasks
catenacyber
reviewed
Dec 3, 2024
| - HAVE_NSS | ||
| - MAGIC | ||
| files: | ||
| - src/output-filestore.c |
There was a problem hiding this comment.
Please do not put filenames because we will move them to rust one day like transforms ;-)
Put min-version: 8 rather ;-)
There was a problem hiding this comment.
Good idea ! Done and pushed on this PR. Let me know if you want me to open another one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests exhibiting issues on filestore.
Ticket
If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:
Redmine ticket: