Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datasets: add test to show hash collisions #2138

Closed
wants to merge 1 commit into from

Conversation

inashivb
Copy link
Member

@inashivb inashivb commented Nov 25, 2024

Ticket

If your pull request is related to a Suricata ticket, please provide
the full URL to the ticket here so this pull request can monitor
changes to the ticket status:

Redmine ticket: https://redmine.openinfosecfoundation.org/issues/7209

Previous PR: #2132

Changes since v2:

  • Trim the hash collision strings list to 125k as it is a spot where the issue can be seen although Suricata is able to exit (in 6m+ w debug flags enabled)

@inashivb inashivb requested a review from catenacyber November 25, 2024 09:31
@inashivb inashivb added tests pass These new tests should pass ticket closed A Redmine ticket provided in the pull request body has been closed labels Nov 25, 2024
@victorjulien
Copy link
Member

Merged in #2149, thanks!

@inashivb inashivb deleted the dataset-hash-issue/v3 branch November 28, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests pass These new tests should pass ticket closed A Redmine ticket provided in the pull request body has been closed
Development

Successfully merging this pull request may close these issues.

2 participants