draft: improve CPU cores affinity to NUMA nodes v4 #11706
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This work let's you set threading settings either: - automatically - to let Suricata decide what cores from what NUMA is better for the given interface - manually - you can per-interface configure threading settings This requires hwloc-devel / hwloc-dev to be installed
lukashino
requested review from
jasonish,
victorjulien and
a team
as code owners
|
ERROR: ERROR: QA failed on build_asan. Pipeline 22393 |
|
Try #12248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #11521
Redmine ticket:
https://redmine.openinfosecfoundation.org/issues/7036
This work allows more precise thread assignment and it is done either
This works with AF-PACKET and DPDK (and should with other capture modes as well). Primary target is workers runmode.
Dependency - hwloc - for the automatic core assignment.
At this point I am not sure why pkg-config doesn't find hwloc in github ci - it works on my machines - in case it fails on yours add LIBS="$LIBS -lhwloc" to your configure.ac