-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
transform: luaxform transform script #12098
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes the detection engine thread context available for transforms to use. The Lua transform requires this value. Issue: 2290
Issue: 2290 This commit extends the hash table logic with an alternate free function that provides the detection engine context. Users that wish to use the next functionality must use the HashListTableInitWithCtx function when initializing the hash table. Using this interface will result in the hash table "free with context" function (new) being used instead.
Issue: 2290 Defer freeing the keyword hash table until the engine context has been freed. This eliminates a double-free from occurring. For the unittests ONLY, clear the keyword_hash to prevent a double free attempt.
Issue: 2290 This commit adds the source files for the new transform -- luaxform.
Issue: 2290
git grep -A 1 -w InspectionBufferSetup shows numbers cases of the pattern: - InspectionBufferSetup - InspectionBufferApplyTransforms Refactor the implementations of those functions into InspectionBufferSetupAndApplyTransforms to reduce function call count. Issuer: 2290
jlucovsky
requested review from
jasonish,
jufajardini and
victorjulien
as code owners
November 7, 2024 15:36
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12098 +/- ##
==========================================
- Coverage 83.23% 79.56% -3.68%
==========================================
Files 906 909 +3
Lines 257647 257683 +36
==========================================
- Hits 214458 205014 -9444
- Misses 43189 52669 +9480
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Information: QA ran without warnings. Pipeline 23291 |
Continued in #12130 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #12072
Add the
luaxform
transform that uses a Lua script to receive and transform a sticky buffer.Lua transforms receive arguments
Arguments are passed to the Lua script as they appear in the rule:
When the transform is invoked, 3 additional arguments are passed (arg count will be 3)
bytes 4
offset 13
hash sha256
The Lua script is responsible for parsing and using the arguments and returning a tuple:
output-buffer, output-buffer-byte-count
I used this Lua script:
Example rule using the Lua script:
Link to ticket: https://redmine.openinfosecfoundation.org/issues/2290
Describe changes:
Updates
Provide values to any of the below to override the defaults.
link to the pull request in the respective
_BRANCH
variable.SV_REPO=
SV_BRANCH=OISF/suricata-verify#2090
SU_REPO=
SU_BRANCH=
LIBHTP_REPO=
LIBHTP_BRANCH=