From 66da5bc14c6de4b08bf938af39088e084472ee3c Mon Sep 17 00:00:00 2001 From: SriHV Date: Wed, 20 Nov 2024 15:43:13 +0000 Subject: [PATCH 1/4] chnages in .ons-tab--row --- src/components/tabs/_tabs.scss | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/components/tabs/_tabs.scss b/src/components/tabs/_tabs.scss index 9a2c9b5836..ac81db31e7 100644 --- a/src/components/tabs/_tabs.scss +++ b/src/components/tabs/_tabs.scss @@ -43,11 +43,11 @@ border-radius: 3px 3px 0 0; color: var(--ons-color-text); display: inline-block; - height: 2.55rem; - line-height: 2.25rem; + height: 2.5rem; + // line-height: 2.25rem; margin: 0 0.5rem 0 0; overflow: visible; - padding: 0 1rem; + padding: 5px 16px 6px; position: relative; text-decoration: underline; @@ -62,10 +62,10 @@ background-color: var(--ons-color-focus); border-bottom: 1px solid var(--ons-color-borders); box-shadow: - inset 0 0 0 9px var(--ons-color-button-secondary), - inset 17px 0 0 0 var(--ons-color-button-secondary), - inset -17px 0 0 0 var(--ons-color-button-secondary), - inset 0 -13px 0 0 var(--ons-color-text-link-focus); + inset 0 0 0 5px var(--ons-color-button-secondary), + inset 15px 0 0 0 var(--ons-color-button-secondary), + inset -14px 0 0 0 var(--ons-color-button-secondary), + inset 0 -9px 0 0 var(--ons-color-text-link-focus); color: var(--ons-color-text-link-focus); // Add transparent outline because Windows High Contrast Mode doesn't show box-shadows @@ -88,10 +88,10 @@ &:focus { background-color: var(--ons-color-focus); box-shadow: - inset 0 0 0 9px var(--ons-color-page-light), - inset 17px 0 0 0 var(--ons-color-page-light), - inset -17px 0 0 0 var(--ons-color-page-light), - inset 0 -13px 0 0 var(--ons-color-text-link-focus); + inset 0 0 0 5px var(--ons-color-page-light), + inset 15px 0 0 0 var(--ons-color-page-light), + inset -14px 0 0 0 var(--ons-color-page-light), + inset 0 -9px 0 0 var(--ons-color-text-link-focus); text-decoration: none; } } From 3be97b458e5645c64f0f3750783eb56fdb531d74 Mon Sep 17 00:00:00 2001 From: SriHV Date: Wed, 20 Nov 2024 16:46:50 +0000 Subject: [PATCH 2/4] adding visual test changes --- ...ponents_tabs_example-tabs-details_0_document_0_desktop.png | 4 ++-- ...mponents_tabs_example-tabs-details_0_document_1_tablet.png | 4 ++-- ...est__components_tabs_example-tabs_0_document_0_desktop.png | 4 ++-- ...test__components_tabs_example-tabs_0_document_1_tablet.png | 4 ++-- src/components/tabs/_tabs.scss | 3 +-- 5 files changed, 9 insertions(+), 10 deletions(-) diff --git a/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs-details_0_document_0_desktop.png b/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs-details_0_document_0_desktop.png index d42335c9de..66d1963def 100644 --- a/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs-details_0_document_0_desktop.png +++ b/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs-details_0_document_0_desktop.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:d5da2774212b021fa4e60f2873c72998db91c0ebc9270747e16d26ae1f67c704 -size 722102 +oid sha256:a1d42eb1c0b45205469c68ca3c081c8e5e6612b17e507e987a27f40e529f33ed +size 722088 diff --git a/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs-details_0_document_1_tablet.png b/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs-details_0_document_1_tablet.png index 64d287e785..f40a744ed0 100644 --- a/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs-details_0_document_1_tablet.png +++ b/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs-details_0_document_1_tablet.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:d5ab28700df3b480e17f11fc1be54c5dbff36f6388321c19d5cb479e37aa0ad5 -size 174635 +oid sha256:4422289b11bb3c91176d0945594ea8bf8eb4ec01ccf08b6d231ea2d9706d582d +size 174638 diff --git a/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs_0_document_0_desktop.png b/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs_0_document_0_desktop.png index d265257a3e..76b8bff4da 100644 --- a/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs_0_document_0_desktop.png +++ b/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs_0_document_0_desktop.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:e41d80e1db739b05edc14f44eccf1990697500c0d6a6efc22d7e4b5b8d33996d -size 54387 +oid sha256:356e2d8aa157381b5b05a7624d53d2730fcdfd373fc2c2f95949ee17974c88ba +size 54371 diff --git a/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs_0_document_1_tablet.png b/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs_0_document_1_tablet.png index a9cbac9d9c..ef0adc4203 100644 --- a/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs_0_document_1_tablet.png +++ b/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs_0_document_1_tablet.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:95676bd31602fc75a8243fb37a634198b84a1e749afb3def423d141eb19f6931 -size 59877 +oid sha256:649e2514eed914dac3e4a1245ecf0ee0e020edd8e90572d5e0581c5918cad3d8 +size 59855 diff --git a/src/components/tabs/_tabs.scss b/src/components/tabs/_tabs.scss index ac81db31e7..cf86ec052f 100644 --- a/src/components/tabs/_tabs.scss +++ b/src/components/tabs/_tabs.scss @@ -44,10 +44,9 @@ color: var(--ons-color-text); display: inline-block; height: 2.5rem; - // line-height: 2.25rem; margin: 0 0.5rem 0 0; overflow: visible; - padding: 5px 16px 6px; + padding: 0.3125rem 1rem 0.375rem; position: relative; text-decoration: underline; From e7c365154b7ba3cb0cc9e7cf26e4d381aa462bb9 Mon Sep 17 00:00:00 2001 From: SriHV <123635670+SriHV@users.noreply.github.com> Date: Tue, 26 Nov 2024 15:36:44 +0000 Subject: [PATCH 3/4] Update src/components/tabs/_tabs.scss Co-authored-by: rmccar <42928680+rmccar@users.noreply.github.com> --- src/components/tabs/_tabs.scss | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/tabs/_tabs.scss b/src/components/tabs/_tabs.scss index cf86ec052f..235c28c552 100644 --- a/src/components/tabs/_tabs.scss +++ b/src/components/tabs/_tabs.scss @@ -46,7 +46,7 @@ height: 2.5rem; margin: 0 0.5rem 0 0; overflow: visible; - padding: 0.3125rem 1rem 0.375rem; + padding: 0.25rem 1rem 0.25rem; position: relative; text-decoration: underline; From 97e76282ca53772b1d56b20d70acc483d28d2888 Mon Sep 17 00:00:00 2001 From: SriHV Date: Wed, 27 Nov 2024 11:08:29 +0000 Subject: [PATCH 4/4] changes in visual tests --- ...ponents_tabs_example-tabs-details_0_document_0_desktop.png | 2 +- ...mponents_tabs_example-tabs-details_0_document_1_tablet.png | 4 ++-- ...est__components_tabs_example-tabs_0_document_0_desktop.png | 2 +- ...test__components_tabs_example-tabs_0_document_1_tablet.png | 4 ++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs-details_0_document_0_desktop.png b/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs-details_0_document_0_desktop.png index 66d1963def..5c40a0432a 100644 --- a/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs-details_0_document_0_desktop.png +++ b/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs-details_0_document_0_desktop.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:a1d42eb1c0b45205469c68ca3c081c8e5e6612b17e507e987a27f40e529f33ed +oid sha256:56b13d93272ee61ef4fd08a87cc7c211e837aaf47adb2ef2aa11babc842b6390 size 722088 diff --git a/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs-details_0_document_1_tablet.png b/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs-details_0_document_1_tablet.png index f40a744ed0..765815beca 100644 --- a/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs-details_0_document_1_tablet.png +++ b/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs-details_0_document_1_tablet.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:4422289b11bb3c91176d0945594ea8bf8eb4ec01ccf08b6d231ea2d9706d582d -size 174638 +oid sha256:3da5559bfd8232bce157f632bcd5037469cb72a202a324cff48bf9f02182ee8e +size 174632 diff --git a/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs_0_document_0_desktop.png b/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs_0_document_0_desktop.png index 76b8bff4da..882c01cd10 100644 --- a/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs_0_document_0_desktop.png +++ b/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs_0_document_0_desktop.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:356e2d8aa157381b5b05a7624d53d2730fcdfd373fc2c2f95949ee17974c88ba +oid sha256:1f2a2c7b835ee5cbc573d4a1c2f436601984a16815c0ffd901c6a4594a831773 size 54371 diff --git a/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs_0_document_1_tablet.png b/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs_0_document_1_tablet.png index ef0adc4203..cc6ecf6a64 100644 --- a/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs_0_document_1_tablet.png +++ b/backstop_data/bitmaps_reference/ds-vr-test__components_tabs_example-tabs_0_document_1_tablet.png @@ -1,3 +1,3 @@ version https://git-lfs.github.com/spec/v1 -oid sha256:649e2514eed914dac3e4a1245ecf0ee0e020edd8e90572d5e0581c5918cad3d8 -size 59855 +oid sha256:9cf7dbd5ec75d0351177e5a93e78429a308fa2b159abc21a5ec4208bad4e1940 +size 59862