Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse nw_ag_flag bool in calculate_winsorised_weight #96

Open
AntonZogk opened this issue Oct 7, 2024 · 0 comments
Open

Reverse nw_ag_flag bool in calculate_winsorised_weight #96

AntonZogk opened this issue Oct 7, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@AntonZogk
Copy link
Collaborator

This `

    nw_ag_flag: str
    column name indicating whether it can't be winsorised-
    boolean (True means it can't be winsorised, False means it can).

`
is a bit confusing.

We can say True means it can be winsorised False it can't. Also nw_ag_flag arg could be renamed to can_be_winsorised
@AntonZogk AntonZogk added the enhancement New feature or request label Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AntonZogk