rename NOT_ENGLAND variable to NI_REGION_CODE #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ense with what code is doing
|
/deploy harrisonj |
|
Deploying to dev cluster with following parameters:
|
|
/deploy scorfs |
|
Deploying to dev cluster with following parameters:
|
SteveScorfield
approved these changes
Sep 21, 2023
src/main/java/uk/gov/ons/ctp/response/casesvc/representation/action/NotifyModel.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What and why?
Fix a bit of confusion around the following bit of code
{{ // if not not england is england. welcome to ras-rm.
if (!NOT_ENGLAND.equals(region)) {
region = "";
}}}
rename NOT_ENGLAND so it can make more sense
How to test?
Jira
https://jira.ons.gov.uk/browse/RAS-769