From 14473ec4cd5fa2ed4b911d64d4972998c7d5ef1d Mon Sep 17 00:00:00 2001 From: Etienne Carriere Date: Wed, 6 Nov 2024 15:21:14 +0100 Subject: [PATCH] [review] plat-stm32mp1: remove unused stm32mp_nsec_can_access_clock() Remove buggy tests on SCMI reset being exposed under wrong API function stm32mp_nsec_can_access_clock(). Remove the code. Function plat_scmi_rd_set_state() and plat_scmi_rd_autonomus() already dynamically call stm32mp_nsec_can_access_clock() to possibly deny effective controller access. Signed-off-by: Etienne Carriere --- core/arch/arm/plat-stm32mp1/scmi_server.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/core/arch/arm/plat-stm32mp1/scmi_server.c b/core/arch/arm/plat-stm32mp1/scmi_server.c index 141a884e0dc..ae37b3491b0 100644 --- a/core/arch/arm/plat-stm32mp1/scmi_server.c +++ b/core/arch/arm/plat-stm32mp1/scmi_server.c @@ -954,9 +954,6 @@ static TEE_Result stm32mp1_init_scmi_server(void) strlen(rd->name) >= SCMI_RD_NAME_SIZE) panic("SCMI reset domain name invalid"); - if (stm32mp_nsec_can_access_clock(rd->reset_id)) - continue; - rstctrl = stm32mp_rcc_reset_id_to_rstctrl(rd->reset_id); assert(rstctrl); if (rstctrl_get_exclusive(rstctrl))