Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug when internalizing EDITNNC #3470

Open
blattms opened this issue Apr 12, 2023 · 0 comments
Open

Possible bug when internalizing EDITNNC #3470

blattms opened this issue Apr 12, 2023 · 0 comments

Comments

@blattms
Copy link
Member

blattms commented Apr 12, 2023

I think there might be an issue here.

If there is an NNC and EDITNNC entry for the same cell pair then we apply EDITNNC directly to the NNC transmissibility but don't represent it internally. But if the NNC is also there because of a fault (i.e. represented by the grid even without it explicitly being specified), then the transmissibility specified via NNC will be added to the transmissibility that the simulator already computes due to the fault. In this case the value of EDITNNC is disregarded for the fault transmissibility.

Not 100% sure which is the correct way here, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant