-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for the DUMPCUPL keyword #4276
Draft
hakonhagland
wants to merge
13
commits into
OPM:master
Choose a base branch
from
hakonhagland:dump_cupl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed inclusion of private header from public header files
Require slaves and master groups to be defined at the first report step
Also add ReseroirCoupling info the ScheduleState serialization test object
Add ReservoirCoupling::CouplingInfo serialization data to the Schedule serialization object.
Remove method that was introduced by a mistake in previous commit.
- Changed copy object to const & - Simplified boost test case logic
Adds support for the RCMASTS keyword.
jenkins build this opm-simulators=5620 please |
Okay. In that case I'll set the PR to draft state in order to avoid inadvertently merging the work before the upstream PR is in the master sources. |
Adds support for the DUMPCUPL keyword used in reservoir coupling.
hakonhagland
force-pushed
the
dump_cupl
branch
from
October 28, 2024 07:21
00f9f20
to
16dbcc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #4272 which should be merged first.
Adds support for the DUMPCUPL keyword in reservoir coupling.