Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds support for the DUMPCUPL keyword #4276

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

hakonhagland
Copy link
Contributor

Builds on #4272 which should be merged first.

Adds support for the DUMPCUPL keyword in reservoir coupling.

Removed inclusion of private header from public header files
Require slaves and master groups to be defined at the first report
step
Also add ReseroirCoupling info the ScheduleState serialization test
object
Add ReservoirCoupling::CouplingInfo serialization data to the Schedule
serialization object.
Remove method that was introduced by a mistake in previous commit.
- Changed copy object to const &
- Simplified boost test case logic
Adds support for the RCMASTS keyword.
@hakonhagland
Copy link
Contributor Author

jenkins build this opm-simulators=5620 please

@bska
Copy link
Member

bska commented Oct 23, 2024

Builds on #4272 which should be merged first.

Okay. In that case I'll set the PR to draft state in order to avoid inadvertently merging the work before the upstream PR is in the master sources.

@bska bska marked this pull request as draft October 23, 2024 08:52
Adds support for the DUMPCUPL keyword used in reservoir coupling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants