Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instrument-specific bias correction to setup, addressing #44 #46

Closed
wants to merge 2 commits into from

Conversation

adamcpovey
Copy link
Collaborator

How's that? Move the SLSTR calibration adjustment into read_imager in order to be applied to any sensor, should we be so inclined.

@adamcpovey adamcpovey requested a review from simonrp84 March 10, 2021 12:40
@adamcpovey adamcpovey self-assigned this Mar 10, 2021
@simonrp84 simonrp84 linked an issue Mar 11, 2021 that may be closed by this pull request
@simonrp84
Copy link
Collaborator

I'm thinking about this again and it might need a more complex solution than we originally thought. This works fine for situations like SLSTR where the corrections are applied to the reflectances, but will cause issues when the corrections have to be applied to radiances (before the rad->ref or rad->bt calculation is performed.
Not really sure what the best solution is, does anyone have some thoughts on this?

@adamcpovey
Copy link
Collaborator Author

I was thinking of forward model bias correction rather than calibration, which will be in radiance space. (Don't been asking me to bias correct the aerosol algorithm against AERONET for years.)

Other thoughts appreciated

@adamcpovey
Copy link
Collaborator Author

I'm thinking about this again and it might need a more complex solution than we originally thought. This works fine for situations like SLSTR where the corrections are applied to the reflectances, but will cause issues when the corrections have to be applied to radiances (before the rad->ref or rad->bt calculation is performed.
Not really sure what the best solution is, does anyone have some thoughts on this?

Looking back at this, when do you expect us to apply such a calibration? I thought the only place we do rad->bt calculations is in the forward modelling of mixed channels radiances.

While I can see that the difference between correcting radiances and reflectances is important, the construction of the code is such that we can only deal with radiances within the instrument reader functions. If you're concerned that some instruments will want to adjust radiance and others reflectance, that implies that these corrections go in the readers and are bespoke. In that case, this code is intended for forward model errors and I should probably relabel it a bit.

Thoughts?

@adamcpovey adamcpovey closed this Oct 14, 2021
@adamcpovey adamcpovey deleted the biascorr_pr branch October 14, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate instrument calibration factors from the readers
2 participants