Fixed exp-val calculation by slicing and conjugate #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 10, 2021 13:33
Signed-off-by: Thien Nguyen <[email protected]>
I put the parity flag in the wrong scope, hence was not set correctly for each projected path. Need to have more than 2 projected qubits to see this bug... Signed-off-by: Thien Nguyen <[email protected]>
Need to restore the state of the base tensor network in VQE mode. Signed-off-by: Thien Nguyen <[email protected]>
so that we can quickly validate the exp-val calculation This script has helped uncover a couple of hard-to-detect bugs.. Signed-off-by: Thien Nguyen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test circuit in #91 helped uncover some subtle bugs in these special exp-val calculation methods.
In the slicing method, the parity tracker flag was not placed in the correct scope -> not properly initialized.
In the double-depth method, the counter and tensor name list must be cached for the base circuit, before adding change-of-basis.