Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack trace on error #9

Open
schaefi opened this issue Aug 29, 2023 · 3 comments
Open

Stack trace on error #9

schaefi opened this issue Aug 29, 2023 · 3 comments

Comments

@schaefi
Copy link
Contributor

schaefi commented Aug 29, 2023

Improve on Error handling

In the beginning errors to the project were always a panic() which leads to interruption at this stage in the code and a stack trace like information. This was not the best solution but it provided exact details about the error and where it happened in the code. With the code changing towards an error reporting up to the main function the information about where in the code something was wrong got lost. In addition the resulting error messages are sometimes unexpressively

Acceptance Criteria

  • go over error messages and check of they are expressive
  • allow stack trace on error if PILOT_DEBUG is set
@schaefi
Copy link
Contributor Author

schaefi commented Aug 29, 2023

An idea to improve: https://github.com/dtolnay/anyhow

@schaefi
Copy link
Contributor Author

schaefi commented Aug 29, 2023

This affects the pilots in the first place, podman-pilot, firecracker-pilot

schaefi added a commit that referenced this issue Aug 29, 2023
Added FlakeError for this condition. Related to Issue #9
@schaefi
Copy link
Contributor Author

schaefi commented Aug 30, 2023

stack trace on error would be nice, but since there is no panic() but error handling up to main it's not so easy to generally create useful trace info

@schaefi schaefi changed the title Improve Error handling Stack trace on error Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant